Date   : Sat, 02 Jul 1983 20:31:11-EDT
From   : goldfarb.ucf-cs@rand-relay
Subject: umodem fix

There is a slight problem with the latest version of umodem (umodem32.c).
A modification to set a logfile default was done in this version and it
will fail to work on some systems because the modifier used a bitwise
instead of a logical 'NOT' to flip a toggle.  The fix is probably not
worth changing the revision number, but I did so  here to avoid confusion
(and besides, I use RCS).  Following is a diff between 3.2 and 3.3 (disregard
the first line, which is RCS info).

1c1
< static char *Rcsid = "$Header: /usr1/grad/goldfarb/src/umodem/RCS/umodem.c,v
3.2 83/07/02 19:26:08 goldfarb Exp $";
---
> static char *Rcsid = "$Header: /usr1/grad/goldfarb/src/umodem/RCS/umodem.c,v
3.3 83/07/02 20:23:23 goldfarb Exp $";
76c76,84
<  *                no logging.
---
>  *                logging.
>  *           -- Version 3.3 Mod by Ben Goldfarb, 07/02/83
>  *                . Corrected problem with above implementation of "LOGDEFAULT".
>  *                A bitwise, instead of a logical, negation operator was
>  *                  used to complement LOGFLAG when the '-l' command line flag
>  *                  was specified.  This can cause LOGFLAG to be true when it
>  *                  should be false.  While I don't consider a one character 
>  *                  replacement to be worthy of a minor revision number, this
>  *                  will prevent confusion.
216c224
< #if LOGDEFAULT
---
> #if LOGDEFAULT == 1
241c249
<         LOGFLAG = LOGDEFAULT;
---
>         LOGFLAG = LOGDEFAULT; /* open (don't open) log file */
259c267
<                 case 'l' : LOGFLAG = ~LOGDEFAULT;  /* turn off log report */
---
>                 case 'l' : LOGFLAG = !LOGDEFAULT;  /* turn off log report */